Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the InsertManyCommand.Options.ordered to false as default #782

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

maheshrajamani
Copy link
Contributor

@maheshrajamani maheshrajamani commented Jan 10, 2024

What this PR does:
Change the InsertManyCommand.Options.ordered to false as default

Which issue(s) this PR fixes:
Fixes #761

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@maheshrajamani maheshrajamani requested a review from a team as a code owner January 10, 2024 14:57
Copy link
Contributor

@Yuqi-Du Yuqi-Du left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maheshrajamani maheshrajamani merged commit e25e8da into main Jan 10, 2024
2 checks passed
@maheshrajamani maheshrajamani deleted the change-insert-many-default branch January 10, 2024 17:24
@@ -204,7 +204,7 @@ public void optionsNotOrdered() throws Exception {
}
],
"options": {
"ordered": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but name of test seems incorrect after change?

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

insertMany default ordered flag to false
4 participants