Changes to have ddl and count profiles #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maheshrajamani
commented
Jan 10, 2024
| @@ -1152,7 +1152,10 @@ public void orderedDuplicateDocumentNoNamespace() { | |||
| "_id": "doc5", | |||
| "username": "user5" | |||
| } | |||
| ] | |||
| ], | |||
There was a problem hiding this comment.
Side effect of a previous merged PR. Need to refactor the test case.
jeffreyscarpenter
approved these changes
Jan 10, 2024
|
@tatu-at-datastax can you have a look as well? |
| } | ||
|
|
||
| count { | ||
| basic.request.timeout = 60 seconds |
There was a problem hiding this comment.
This sounds bit high (as does basic request timeout of 20 secs), but easy enough to change later on I suppose.
tatu-at-datastax
approved these changes
Jan 10, 2024
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Changes to have ddl and count profiles
Which issue(s) this PR fixes:
Fixes #783
Checklist