-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #767: Second part of "no-index" changes: allow large non-indexed String values, implicit allow for "$vector" #792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far 👍
… "too big string" error
…ex) and value (post-no-index)
Remaining issue: when returning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good except for the clarification on $vector
field
@maheshrajamani On But I wonder... if I'll have to think about this bit more, thanks! |
Sounds like implicit addition of |
Need to make change for auto-inclusion of |
Ready for re-review. |
@maheshrajamani "$vector" handling changed as discussed: any other concerns? (I know you have approved but wanted to double-check before merging) |
@tatu-at-datastax Changes LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Completes changes needed by #767 by:
_id
for query projections, i.e. always index)These are resolved by refactoring validation logic into smaller parts, run at different times during shredding process.
Which issue(s) this PR fixes:
Fixes #767
Checklist