Handle DOCUMENT_ALREADY_EXISTS error on insert #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…what was attempted as part of the insert. This is possible if WTE exception happens and retry of the row gets LWT error.
Yuqi-Du
reviewed
Jan 16, 2024
| final UUID txId = result.one().getUuid("tx_id"); | ||
| if (doc.txID().equals(txId)) { | ||
| return Uni.createFrom().item(doc.id()); | ||
| } |
There was a problem hiding this comment.
Three retry will have the same txId, is that correct?
There was a problem hiding this comment.
Yes, retries are done by the driver with the same bind values
Yuqi-Du
approved these changes
Jan 16, 2024
…/jsonapi into concurrent-insert-error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Check LWT error for insert's are because of WTE retries.
Which issue(s) this PR fixes:
Fixes #801
Checklist