Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid $ operator use case, INVALID_REQUEST typo fix #803

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Conversation

Yuqi-Du
Copy link
Contributor

@Yuqi-Du Yuqi-Du commented Jan 17, 2024

What this PR does:
{ "find": { "filter": { "address": { "street": { "$in" :["xxx"] } } } } }
is a misuse of $ operator, if $in is intended here, should be
{ "find": { "filter": { "address.street": { "$in" :["xxx"] } } } }

fix typo: INVALID_REQEST -> INVALID_REQUEST

Which issue(s) this PR fixes:
Fixes #798 #796

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@Yuqi-Du Yuqi-Du requested a review from a team as a code owner January 17, 2024 00:22
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good: just need to fix one IT wrt INVALID_REQUEST value.

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Yuqi-Du Yuqi-Du merged commit 832aeb2 into main Jan 17, 2024
2 checks passed
@Yuqi-Du Yuqi-Du deleted the filter-bug-fix branch January 17, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid filter, misuse of $ operators
3 participants