Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation of paths used for indexing "allow"/"deny" lists. #804

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

tatu-at-datastax
Copy link
Contributor

What this PR does:

Adds validation of "indexing" options paths (in "allow" / "deny" lists), tests to verify.

Which issue(s) this PR fixes:
Fixes #790

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

}

@Test
public void createCollectionWithIndexing() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split existing long test method in two parts since they were testing different aspects.

@tatu-at-datastax tatu-at-datastax marked this pull request as ready for review January 17, 2024 01:30
@tatu-at-datastax tatu-at-datastax requested a review from a team as a code owner January 17, 2024 01:30
@tatu-at-datastax
Copy link
Contributor Author

@maheshrajamani Allowing $vector now, modified tests to include that, as well as check that brackets not allowed.

@tatu-at-datastax tatu-at-datastax merged commit 57d7607 into main Jan 17, 2024
2 checks passed
@tatu-at-datastax tatu-at-datastax deleted the tatu/790-validate-indexing-paths branch January 17, 2024 17:24
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate paths used for indexing options for CreateCollection
3 participants