Fixes #821: apply max-object-properties/max-doc-properties only on indexed Objects #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dexable Objects
…perties than indexed ones
| | `stargate.jsonapi.document.limits.max-object-properties` | `int` | `1000` | The maximum number of properties any single indexable object in a document can contain. | | ||
| | `stargate.jsonapi.document.limits.max-document-properties` | `int` | `2000` | The maximum total number of properties all objects in a document can contain. | | ||
| | `stargate.jsonapi.document.limits.max-number-length` | `int` | `100` | The maximum length (in characters) of a single number value in a document. | | ||
| | `stargate.jsonapi.document.limits.max-string-length-in-bytes` | `int` | `8000` | The maximum length (in bytes) of a single indexable string value in a document. | |
There was a problem hiding this comment.
Adding missing "indexable": was already changed to only validate indexable Strings.
| @@ -282,11 +282,6 @@ private void validateObjectValue( | |||
| validateDocDepth(limits, depth); | |||
|
|
|||
| final int propCount = objectValue.size(); | |||
| if (propCount > limits.maxObjectProperties()) { | |||
There was a problem hiding this comment.
Moved from "full doc" validation to later "indexable only doc" validation.
|
Thank you @maheshrajamani ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Changes validation of Document limits so that maximum Object property limits only consider indexed fields.
Which issue(s) this PR fixes:
Fixes #821
Checklist