Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for all and size operator #86

Merged
merged 6 commits into from
Feb 9, 2023
Merged

Changes for all and size operator #86

merged 6 commits into from
Feb 9, 2023

Conversation

maheshrajamani
Copy link
Contributor

No description provided.

@maheshrajamani maheshrajamani requested a review from a team as a code owner February 8, 2023 19:02
tatu-at-datastax
tatu-at-datastax requested changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok looks pretty good: one bug I think (SIZE_GROUP vs ALL_GROUP), and I think it'd make sense to add tests slightly not only test for exact array match.

Oh, and to test against long(er) String: at least 24 characters, as that will use MD56 hash (shorter ones are included as-is).

@maheshrajamani maheshrajamani mentioned this pull request Feb 9, 2023
Merged
@maheshrajamani maheshrajamani merged commit 75ad05e into main Feb 9, 2023
@maheshrajamani maheshrajamani deleted the all branch February 9, 2023 13:38
vkarpov15
vkarpov15 reviewed Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 left review comments

@tatu-at-datastax tatu-at-datastax tatu-at-datastax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maheshrajamani @vkarpov15 @tatu-at-datastax