index creation failure msg, usage with collection not fully indexed #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/io/stargate/sgv2/jsonapi/exception/ErrorCode.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/exception/ErrorCode.java
Outdated
Show resolved
Hide resolved
...in/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/CreateCollectionOperation.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/exception/ErrorCode.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I like improvements here, but I think we can probably improve on wording & inclusion of information (collection name should be included in all, I think). And for "missing index" case indicate it as such (instead of suggesting operation that failed was create-collection -- if I understood logic correctly).
vkarpov15
reviewed
Feb 19, 2024
src/main/java/io/stargate/sgv2/jsonapi/exception/mappers/ThrowableToErrorMapper.java
Show resolved
Hide resolved
...in/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/CreateCollectionOperation.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/exception/mappers/ThrowableToErrorMapper.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are chances of the collection creation is successful, but not fully indexed.
Even though we now get less failures because index creation changes into serial execution.
This PR will throw a JsonApiException, when there is table creation failure or index creation failure.
Also, if user is using a not fully indexed collection, also prompt with proper error msgs.
Which issue(s) this PR fixes:
Fixes #812
Checklist