Fixes #884: unify JSON Object member reference to "property" (from "field" etc) #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,9 +61,9 @@ public enum ErrorCode { | |||
|
|
|||
| SHRED_BAD_EJSON_VALUE("Bad EJSON value"), | |||
|
|
|||
| SHRED_BAD_VECTOR_SIZE("$vector field can't be empty"), | |||
| SHRED_BAD_VECTOR_SIZE("$vector value can't be empty"), | |||
There was a problem hiding this comment.
Since this is more general reference (used from multiple places), cannot refer as "property", but that is implied by name $vector -- hence "value".
Yuqi-Du
approved these changes
Feb 20, 2024
jeffreyscarpenter
pushed a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Unifies terms used to refer to key/value pairs in JSON Document by using "property", over alternate names like "field"
Which issue(s) this PR fixes:
Fixes #884
Checklist