collection limit rollback change #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFAULT_INDEXES_AVAILABLE_PER_DATABASE 50 to 100, fail on DB 50 guardrail
jeffreyscarpenter
requested changes
Mar 6, 2024
src/main/java/io/stargate/sgv2/jsonapi/config/DatabaseLimitsConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/config/DatabaseLimitsConfig.java
Outdated
Show resolved
Hide resolved
...in/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/CreateCollectionOperation.java
Show resolved
Hide resolved
...in/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/CreateCollectionOperation.java
Outdated
Show resolved
Hide resolved
...in/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/CreateCollectionOperation.java
Outdated
Show resolved
Hide resolved
...in/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/CreateCollectionOperation.java
Outdated
Show resolved
Hide resolved
|
Do we need to add a new test case or two to make sure this is working as expected @Yuqi-Du ? |
I have tested this by writing our createCollection and deleteCollection code against Astra by using driver. |
Yuqi-Du
changed the title
…before, and rollback is enabled, then drop the collection
|
I have added a 'feature flag' to disable the rollback. |
...in/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/CreateCollectionOperation.java
Outdated
Show resolved
Hide resolved
...in/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/CreateCollectionOperation.java
Outdated
Show resolved
Hide resolved
...in/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/CreateCollectionOperation.java
Outdated
Show resolved
Hide resolved
Yuqi-Du
force-pushed
the
collection_limit_short_term_approach
branch
from
399fd85 to
d600cb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rollback change for Astra collection limit relaxation, and part of the short term solution we have for db collection limit.
In general, before violates Data API collection guardrail, if tenant hit the astra side guardrail and has indexes creation failure, Data api will also drop the table(plus indexes)
if index creation violates DB index limit and collection not existed before, and rollback is enabled, then drop the collection
Which issue(s) this PR fixes:
Fixes #912
Checklist