Add support for $each modifier of $push update operator
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
reviewed
Feb 10, 2023
| UpdateOperator.PUSH.resolveOperation( | ||
| objectFromJson( | ||
| """ | ||
| { "array" : { "$each" : 365 } } |
There was a problem hiding this comment.
Another good case to test would be using $each to push an array. For example, $push: { $each: [[-80, 25], [-121, 37]] } should push 2 array elements.
There was a problem hiding this comment.
@vkarpov15 Thanks! Yes, good idea, will add.
tatu-at-datastax
changed the title
$each modifier of $push update operator$each modifier of $push update operator
maheshrajamani
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #72 basic
$pushoperation was added but it did not support modifiers. The most important one to add (plus one required to support any of the others) is$each; this PR adds support.