fix: estimateMessageFee
should handle from_address
as checksum'ed eth address
#1054
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
While using
estimateMessageFee
in our deposit/withdraw code, we encountered that passingfrom_address: 0x01FB18b564c106873ea2951F0f099Af7527E8680
argument toestimateMessageFee
causes the following error:From the source code,
starknet.js
seem to convert thehex string
tobigint
and then back tohex
which loses the leading0x0…
ourfrom_address
address, which causes incorrectfrom_address
address to be sentRPC version (if applicable)
v0_6
,v0_7
Usage related changes
No breaking changes
Development related changes
No breaking changes
Checklist: