Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove [warning] from typedoc for external usage #1095

Merged
merged 7 commits into from
May 17, 2024
Merged

fix: remove [warning] from typedoc for external usage #1095

merged 7 commits into from
May 17, 2024

Commits on May 17, 2024

  1. test: Improve tests performance (starknet-io#1121) 

    * test: fix transaction retry interval fallback for devnet tests

* test: remove test.only
    @lukasaric @0xknwn
    lukasaric authored and 0xknwn committed May 17, 2024
    Configuration menu
    Copy the full SHA
    55388eb View commit details
    Browse the repository at this point in the history

  2. Update _test.yml (starknet-io#1126)

    @ivpavici @0xknwn
    ivpavici authored and 0xknwn committed May 17, 2024
    Configuration menu
    Copy the full SHA
    a335db7 View commit details
    Browse the repository at this point in the history

  3. fix: rename the @param to match the definitions 

    this commit changes the typedoc that do not match the function declaration
    @0xknwn
    0xknwn committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6d35525 View commit details
    Browse the repository at this point in the history

  4. fix: add a space before typedoc <br/> so that it catches the name 

    when a @param contains an html tag, it should not be attached to the parameter
name otherwise it does consider the tag is part of the name. This commit
detaches the name from the tag
    @0xknwn
    0xknwn committed May 17, 2024
    Configuration menu
    Copy the full SHA
    1786345 View commit details
    Browse the repository at this point in the history

  5. fix: improve function declaration so that typedoc matches it 

    this is a specific case when a function has several declarations and the first
one does not match the typedoc because the parameter is optional. This commit
simplifies the declaration by making the comment optional with a ?.
    @0xknwn
    0xknwn committed May 17, 2024
    Configuration menu
    Copy the full SHA
    9dfd83f View commit details
    Browse the repository at this point in the history

  6. fix: reintroduce the parameter name 

    change the declaration of a function so that the parameter name appears.
To do so it moves the assignement in the function.
    @0xknwn
    0xknwn committed May 17, 2024
    Configuration menu
    Copy the full SHA
    9808730 View commit details
    Browse the repository at this point in the history

  7. fix: remove unused type declaration and export 

    removes a declaration from account that is not used in the code and
redundant with the exact same one in the provider file. export the
declaration that is the one really used.
    @0xknwn
    0xknwn committed May 17, 2024
    Configuration menu
    Copy the full SHA
    56debea View commit details
    Browse the repository at this point in the history