Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ignore warning #6736

Closed
1 of 2 tasks
gaetbout opened this issue Nov 25, 2024 · 6 comments · Fixed by #6743
Closed
1 of 2 tasks

feat: Ignore warning #6736

gaetbout opened this issue Nov 25, 2024 · 6 comments · Fixed by #6743
Labels
enhancement New feature or request

Comments

@gaetbout
Copy link
Contributor

gaetbout commented Nov 25, 2024

Feature Request

Describe the Feature Request

In some situation I'd like to be able to ignore specific warnings.

Describe Preferred Solution

Some sort of #![allow(dead_code)] or #![allow(colliding_path)] when dealing with component having the same storage slot.

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

  • Yes
  • No
@gaetbout gaetbout added the enhancement New feature or request label Nov 25, 2024
@orizi
Copy link
Collaborator

orizi commented Nov 25, 2024

you want to specifically allow dual access to the same storage area?

@gaetbout
Copy link
Contributor Author

Yes, we need it, for example when upgrading to have access to the slots, while extracting the code in a component

@orizi
Copy link
Collaborator

orizi commented Nov 25, 2024

I'm thinking of something like #[legacy] to mark a field we shouldn't check

@gaetbout
Copy link
Contributor Author

That would solve this specific issue.
But some other users might want to be able to ignore other warnings :/

@orizi
Copy link
Collaborator

orizi commented Nov 25, 2024

some are already ignored using some allow or other - i'm not certain at all we want to ignore any specific warning in context.

@gaetbout
Copy link
Contributor Author

Then I see the need for a way to indicate that I don’t want a warning about conflicting storage keys.

@orizi orizi linked a pull request Nov 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants