Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Make the prefix configurable #26

Open
tmttn opened this issue Oct 3, 2020 · 6 comments
Open

Make the prefix configurable #26

tmttn opened this issue Oct 3, 2020 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issue dedicated to the Hacktoberfest on-hold Issue for which I need time to think about

Comments

@tmttn
Copy link
Contributor

tmttn commented Oct 3, 2020

Feature Request

Is your feature request related to a problem? Please describe.
Making the prefix configurable allows the server admin to personalize it.

Describe the solution you'd like
Store the prefix in the database per server. If no prefix is configured, use the default one. Validate the prefix for the format prefixName!.

Describe alternatives you've considered
None 🤔

Teachability, Documentation, Adoption, Migration Strategy

config: {
    command: 'setprefix',
    name: 'Set bot prefix',
    description: 'Change the default bot prefix',
    usage: `${prefix}setprefix <prefix>`,
    displayHelp: true,
    permissionNeeded: 'ADMINISTRATOR',
  },
@tmttn tmttn added the enhancement New feature or request label Oct 3, 2020
@tmttn
Copy link
Contributor Author

tmttn commented Oct 3, 2020

I would like to work on this ofc. ;-)

@LucasCtrl
Copy link
Member

At the moment, I don't think this feature is necessary.
However, I'll leave it open if the necessity arises.

@LucasCtrl LucasCtrl added good first issue Good for newcomers hacktoberfest Issue dedicated to the Hacktoberfest on-hold Issue for which I need time to think about labels Oct 4, 2020
@tmttn
Copy link
Contributor Author

tmttn commented Oct 4, 2020

I was trying out an implementation for this, but it became annoying very quickly, especially in the status / help messages... 😭

@ghost
Copy link

ghost commented Oct 4, 2020

I don't think this is necessary, since there isn't any other bot with this prefix. Anyway, it's a good idea to implementate it. PRs welcome, and Lucas could do something too

@ghost
Copy link

ghost commented Oct 4, 2020

I would do this with a JSON db, just like this:
{"serverId": "prefix" | "default prefix"}

@tmttn
Copy link
Contributor Author

tmttn commented Oct 4, 2020

That's what I was doing, and that part is fine. It's mostly the status message that was giving me a headache, because that one is not server specific. It's specific to the bot user in general.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issue dedicated to the Hacktoberfest on-hold Issue for which I need time to think about
Projects
None yet
Development

No branches or pull requests

2 participants