-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback: I like it a lot! #3
Comments
@sotte Thanks a lot for your feedback :) |
Will get back to you. I also noticed that some rolls while typing faster trigger the hold behavior. I also have to tweak the timeouts a bit. One thing I'll definitely will implement is custom shift keys with mod tap behavior: |
Yep, that happened to me too... I'm working on this, I hope I'll fix that in next release |
@sotte , I've just release new version of the library. I fixed the bug with sticky hold behavior. |
Nice @stasmarkin , I'll give it a try next weekend. Quick update from my side: Also just FYI: I also played with a newer version of achordion. It has this "typing streak" feature which really improved the home row mod behavior. |
@sotte Can you contact me with email? I think I can help you. |
I am having a misfire almost every word. I type fast, but am definitely not going to compromise that for HRMs. My configuration is located here (additionally, see PR for macro enhancements). I followed the advice on the wiki for adjusting timeouts, but could not get something that works for me after a few hours of tweaking. In its current state, I have very exaggerated numbers for timeout values. Until this problem can be fixed, I am going to have to return to my bottom-row modifiers using standard tap-dance. A shame, since I like the flexibility this library lends. |
Absolutely love this project. I avoided HRM's previously after trying them as I hated the feeling of always waiting for the TAPPING_TERM, and felt that I had very many misfires. After 3 (very long) days with sm_td I can safely say that it will be a mainstay in my configuration. Incidentally I discovered qmk-vim on the same weekend, and the combination of the two libraries has proved to be the trickiest part as the custom keycodes required by sm_td currently break qmk-vim. But I saw #11 that a possible sm_td implementation without custom keycodes is in the works, which would be amazing. |
I am eager to try your solution, but I am not sure if the implementation is stable enough. Would you recommend version 0.4.1 or should I wait? |
@sotte I have a similar issue, what is your current workaround? I don't find any clue here https://github.com/sotte/sotte_qmk_keyboard_layout/blob/5941111b76f67cd54617bb37cc12f10eda2cfcfd/keyboards/crkbd/keymaps/sotte_exp_td/keymap.c#L139 |
@42Craft I'm working on 0.5.0 as there are many internal changes introduced. |
I tried it today. It works quite well! I am amazed. Awesome :D I do get some false positives, mostly on combinations involving the same side of the keyboard. For example:
What timeout would you recommend for SMTD_TIMEOUT_RELEASE? A solution like Accordion would help but I guess this is not ideal. |
I call this "sticky pinkies" problem. The weaker is finger, the later we release a key with this finger. So I's harder to correctly interpret user's intention. |
The situation improved by tweaking my timeout release settings. The only false positives I encounter now mostly seem to be related to the left section. For example, typing
However, when I type only Is there anything you can recommend to further improve the settings? I feel like we are close to a working setup. I am excited about the functionality your library offers. It's really nice! I am currently using the following settings:
|
I think in these cases you do a 3-finger roll. In other words, you press the 3rd key before you actually release the first one. |
Thanks for the work on the library, it's been my favorite so far for QMK 😄! I did notice the three finger rolling problem as well, mainly with words such as "question" or "bastion" ending in "ion" which results in the "i" not getting sent and sometimes an accidental trigger of GUI which I have configured on the hold for "i". I'm looking forward to the new version whenever that comes out! |
Hello @stasmarkin - just chiming in to say thanks a lot for this; I've tried hrm before and it was always a lot finicky with lag and timing issues. I haven't dug too deeply yet but the initial experience on integrating this is quite marked and definitely for the better. I still see some misfires when I'm on a fast typing streak (like when typing in this comment) - but I suppose I need to RTFM a bit more on the customization wiki pages. Keep up the great work! ps: there's a typo on the code sample in Getting started section that results in an empty fn & compilation error since subsequent switch is outside. not a biggie & most ppl will figure it out but good to fix.
|
Just want to give you some feedback. I tried out
sm_td
and I like it a lot so far.I normally have home row mods in the bottom row, as I can't get used to the normal mod tab behavior. I also tried achordion by getreuer, which improved the situation a lot, but I still had many misfires. With
sm_td
it works really smoothly. The right pinky sometimes causes misfires. But I think I can improve this by configuringsm_td
a bit.Just a big thanks from me!
The text was updated successfully, but these errors were encountered: