Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatiablity with Achordion bilateral combinations? #6

Open
soitchy opened this issue Aug 29, 2024 · 9 comments
Open

Compatiablity with Achordion bilateral combinations? #6

soitchy opened this issue Aug 29, 2024 · 9 comments

Comments

@soitchy
Copy link

soitchy commented Aug 29, 2024

One thing that Achordion solved for me was preventing accidental mod activation when typing rolls, since mods couldn't be activated on the same hand. Is it possible to keep this behavior with sm_td?

@stasmarkin
Copy link
Owner

SM_TD doesn't monitor whether you press the hotkey with two hands or with one hand.
However, SM_TD is designed to correctly interpret the typing roll, so it can distinguish if your keys are overlapped by typing intention or by hold+tap intention.
So SM_TD solves the same problem, but in a completely different way.

@stasmarkin
Copy link
Owner

@soitchy
Actually it's not a hard task to add bilateral combinations to SM_TD, but I'm not sure if it's really useful.
Have you already tried SM_TD and still feel that you need this feature?

@soitchy
Copy link
Author

soitchy commented Sep 3, 2024

@soitchy Actually it's not a hard task to add bilateral combinations to SM_TD, but I'm not sure if it's really useful. Have you already tried SM_TD and still feel that you need this feature?

I've been using sm_td for a few days now. I wouldn't say that I need bilateral combinations. After adjusting timings I've got sm_td setup in such a way that rolls are not firing modifiers.

@stasmarkin
Copy link
Owner

stasmarkin commented Sep 3, 2024

Glad to hear that!
Could you please share your configuration and timings too, please?
I'm looking for the best default solution, so I'd like to see how other people use sm_td

@soitchy
Copy link
Author

soitchy commented Sep 3, 2024

I'm still fiddling with settings, but when I get it where I like it I'll share.

@iovis
Copy link

iovis commented Sep 7, 2024

Glad to hear that! Could you please share your configuration and timings too, please? I'm looking for the best default solution, so I'd like to see how other people use sm_td

I'm loving the library, been using it for a couple of days, but I still sometimes run into issues with rolling keys. Certain words like "feat", "fast", "have", "vim" or "me" are hard to get right. It's especially evident in vim when I do things like "viw" or things like that.

There's an argument on whether I should use different keys for these layer mods, but my thumbs seem to not be able to handle it without giving me RSI. That's why I got excited when I saw your library and, to be honest, it's the closest it's gotten to perfect!

Also, when I roll certain symbols very fast, they seem to hold "Shift" while I do it (although I think this may be a QMK thing). It only happens if I do it within the TAPPING_TERM. For instance:

KC_EXLM KC_EQL # will output `!+` instead of `!=`

You wanted to see configs, so here's mine!
https://github.com/iovis/qmk_userspace/blob/f7be0d2bd3dca6cf0f1bb0aa2f77bd28b852f3f5/keyboards/boardsource/unicorne/keymaps/iovis/keymap.c

@stasmarkin
Copy link
Owner

but I still sometimes run into issues with rolling keys. Certain words like "feat", "fast", "have", "vim" or "me" are hard to get right.

I see you already lowered SMTD_TIMEOUT_RELEASE. That's the right thing to do for this kind of problem, and it usually helps. So I'm afraid there's not much more to do. The only thing to do right now is to lower it further, say to 7 or 5.
However, in the next versions of sm_td I will add some additional mechanisms to evaluate the hold vs. tap decision, so that might help.

KC_EXLM KC_EQL # will output !+ instead of !=

I don't really see how sm_td could be involved here. Since sm_td doesn't touch any of these keys, it simply bypasses them without making any changes. Could you please check if this happens without sm_td?

@iovis
Copy link

iovis commented Sep 8, 2024

I see you already lowered SMTD_TIMEOUT_RELEASE. That's the right thing to do for this kind of problem, and it usually helps. So I'm afraid there's not much more to do. The only thing to do right now is to lower it further, say to 7 or 5.

Thank you for confirming! I reduced it to 5, 3 and 1. I do have fewer false triggers but it still does trigger from time to time when I'm typing. I'm starting to wonder if it may be something on my rolling technique that doesn't play well with this. In any case, it's still the closest I've gotten to mods working flawlessly!

However, in the next versions of sm_td I will add some additional mechanisms to evaluate the hold vs. tap decision, so that might help.

I'm excited to see what you have planned!

I don't really see how sm_td could be involved here. Since sm_td doesn't touch any of these keys, it simply bypasses them without making any changes. Could you please check if this happens without sm_td?

I managed to reproduce with vanilla QMK —with 2 keyboards—, but for some reason I'm having trouble finding an issue about it on their GitHub. In any case, not this library's problem, I probably found it because I found your post on Reddit and got excited to try my Corne again haha.

@42Craft
Copy link

42Craft commented Oct 12, 2024

@soitchy Actually it's not a hard task to add bilateral combinations to SM_TD, but I'm not sure if it's really useful. Have you already tried SM_TD and still feel that you need this feature?

It would definitely fix the last of my problems, but in my opinion it seems to be more like a quickfix. Maybe it's time better spend on tweaking your library. My experience also is that it's almost perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants