[5.x] Fix augmentation issues for URL nav items #10086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnathonKoster
approved these changes
May 18, 2024
There was a problem hiding this comment.
After reviewing this, these changes seem okay to me. Future refactors might be able to allow for more specific targeting of the bulk augmentation reference, but these changes preserve the new behavior for entries, while preventing issues with other data-types without major performance issues (working is better than fast, but not working!).
Great work!
|
Thanks both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with URL nav items not being augmented properly.
I managed to track down the issue to some changes made in #9636. As part of those changes, a
getBulkAugmentationReferenceKeymethod has been added. It seems like the returned key is unique for entry nav items but wasn't for URL-based nav items.This PR appends the nav item ID to the returned reference key which seems to fix the issues.
Fixes #10055.
Fixes #10080.