Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix actions in assets, forms, and form submissions #10132

Merged
merged 4 commits into from
May 21, 2024

Conversation

duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented May 21, 2024

Commented edited by Jason.

This pull request fixes an issue where running actions in the Asset Editor, Form submission listing, and Form listings would result in errors, due to the getItemData method being missing from the respective ActionControllers.

Fixes #10129
Fixes #10141
Fixes the same issue, but for forms. Unreported.

@duncanmcclean duncanmcclean changed the title [5.x] Fix actions on asset editor [5.x] Fix actions in Asset Editor May 21, 2024
@jasonvarga
Copy link
Member

Changed this to just the bare minimum at the moment: implementing the abstract method. It's not even used right now.

From #6375:

Currently the asset editor closes whenever an action completes, which may not be desirable for all actions, but I didn’t want to mess with that in this PR. This could be looked at in a future PR.

@jasonvarga jasonvarga changed the title [5.x] Fix actions in Asset Editor [5.x] Fix actions in assets, forms, and form submissions May 21, 2024
@jasonvarga
Copy link
Member

jasonvarga commented May 21, 2024

I've consolidated the 3 related issues/PRs into one and updated the description.

@jasonvarga jasonvarga merged commit cc7d215 into 5.x May 21, 2024
33 checks passed
@jasonvarga jasonvarga deleted the fix/asset-publish-form-actions branch May 21, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't delete form submissions 500 error in JS console trying to delete an asset after 5.3.0 upgrade
2 participants