Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Update GitHub Actions workflow versions #10136

Merged
merged 1 commit into from
May 21, 2024

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented May 21, 2024

This PR updates the versions of the GitHub Actions workflows.
Some changes are unproblematic in my opinion, but some need some more considerations or are not testable by me.

Laravel Pint

If you want to run a specific pint version, you can configure that using the following configuration.

        - name: "Laravel Pint Action"
          uses: aglipanci/laravel-pint-action@v2
          with:
            pintVersion: 1.15.3

v1 runs using the latest version of pint as far as I know.

Slack Notifications

The last of the changes, were on failure of tests and js-tests when the tests were scheduled are not testable by me, if it not works, these changes should probably be reverted.

  • technote-space/workflow-conclusion-action
  • 8398a7/action-slack (v3 requires explicitly listing the fields)

@jasonvarga
Copy link
Member

Some changes are unproblematic in my opinion

Which were problematic?

@Jubeki
Copy link
Contributor Author

Jubeki commented May 21, 2024

The slack notifications, because I can not test them.
and maybe tj-actions/changed-files because I don't know much about this action.

@Jubeki
Copy link
Contributor Author

Jubeki commented May 21, 2024

Maybe on another note: if you as maintainer are annoyed with having all workflows run twice (due to push and pull_reqest), I can also send a PR which changes the behaviour to only run the workflows once (Similar to a PR which I send to Laravel Framework: laravel/framework#44053)

@Jubeki Jubeki marked this pull request as ready for review May 21, 2024 14:52
@jasonvarga
Copy link
Member

I mean, is there a reason you are updating these versions? Is there some kind of problem with the versions they are on at the moment?

@Jubeki
Copy link
Contributor Author

Jubeki commented May 21, 2024

For the actions/* which are maintained by Github, they are mainly Performance Improvements and moving from deprecated node versions to supported node version. The other versions also use deprecated or unsupported node versions, which are bumped in their respective major versions. See the following notices, which appear in the Actions Tab:

Screenshot 2024-05-21 at 21 05 35

Though there are still deprecations notices, they are fewer:

In general I think it is good to keep dependencies (in this case only dev Dependencies) up to date, because they can include performance improvements or security fixes. There is no real other reason (so changes can be reverted by the maintainers if some versions should not be updated, or to be tested in some other way).

You can take this PR as a starting point, or discuss internally if you want to update in some other way or keep the versions running like they are now.

@jasonvarga
Copy link
Member

All good, thanks! We just like to know the reasons for a change.

@jasonvarga jasonvarga merged commit df74120 into statamic:5.x May 21, 2024
16 checks passed
@jasonvarga
Copy link
Member

Maybe on another note: if you as maintainer are annoyed with having all workflows run twice (due to push and pull_reqest), I can also send a PR which changes the behaviour to only run the workflows once (Similar to a PR which I send to Laravel Framework: laravel/framework#44053)

That sounds good. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants