-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Merge config field defaults into field config #10139
Merged
jasonvarga
merged 12 commits into
5.x
from
merge-config-field-defaults-into-field-config
Jun 3, 2024
Merged
[5.x] Merge config field defaults into field config #10139
jasonvarga
merged 12 commits into
5.x
from
merge-config-field-defaults-into-field-config
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
commented
May 21, 2024
Doing so will fix #10198.
I'm gonna split this PR into two. The other half is in #10246. |
…ts defined in the fieldtype, and for different types.
I don't consider the "default" changes (like automatic line breaks in markdown) breaking as we expected them as of 5.0.0. I would consider us not changing them to be bugs. Plus, in 4.x you probably would have the defaults saved to your yaml file (which in automatic line break's case was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #10106, where the Code Fieldtype wouldn't retain the selected mode even when the
mode_selectable
config option looked like it was enabled (by default, it's set totrue
).This was happening since the
Code::process()
method saves just the code value and not the mode/language whenmode_selectable
isfalse
:cms/src/Fieldtypes/Code.php
Lines 152 to 154 in 73c48a4
cms/src/Fieldtypes/Code.php
Lines 194 to 197 in 73c48a4
This PR fixes that by ensuring the default values for fieldtype config fields are included in the output of
Fieldtype::config()
.Fixes #10106.