-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Fix dark mode for Set Picker #10173
Conversation
Please refer to the sample and select the appropriate dark shades. |
What sample are you referring to? This looks pretty solid to me. Right in line with everything else. |
I mean other similar components... However, it is alright if you believe it is correct. |
And I'm the only one banned from adding pull requests to the dark mode! 👀 |
You're not banned – you just previously pushed PRs for stuff we already finished. |
Fair enough – i was just trying to save you effort because i was just working on dark mode stuff full time. i'm back off now as i already pushed everything i could find – so feel free to PR again! ❤️ |
I feel that I've contributed adequately to this update. If there are any additional changes that others may have missed, I'll be sure to push them. I'm planning to focus on other updates. |
@peimn Thank you! |
You're welcome! |
The current Set Picker is not great in Dark Mode:
This PR improves Set Picker dark mode:
Resolves #10125