[5.x] Fix link fieldtype state #10182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9526
When the link fieldtype is created, it initializes its state from the metadata. (e.g. the dropdown option).
Fresh link fields have nulls in the meta data (the "None" option in the dropdown, for example).
When you switch into live preview, or a bard field gets saved, the components get recreated. Since it gets reinitialized from the meta, it'll reset various things and that's why you see the dropdown revert to "None".
This PR maintains the meta data appropriately.
The meta data is called
initialThis,initialThat, etc and updating those is a little weird, but I don't want to get into renaming those right now.