[5.x] Fix error when serializing eloquent query builders #10189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the
{{ nocache }}
tag and Statamic'sEloquentQueryBuilder
, where passing eloquent query builder instances to partials would cause an error to be thrown:This error was happening due to the
PDO
object, which is nested in Eloquent's query builder not being serializable. This PR fixes that by removing theconnection
andgrammar
properties from the query before serializing, then sets them again when unserializing.Fixes statamic/eloquent-driver#291.