Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Revert select modifier #10218

Merged
merged 1 commit into from
May 29, 2024
Merged

[5.x] Revert select modifier #10218

merged 1 commit into from
May 29, 2024

Conversation

jasonvarga
Copy link
Member

This temporarily removes the select modifier to fix #10211 until we can find a solution.

@godismyjudge95
Copy link
Contributor

Oops, wonder why tests didn't catch that?

@jasonvarga
Copy link
Member Author

jasonvarga commented May 29, 2024

Clearly that particular situation isn't covered by tests. Not your fault.

We will bring back the modifier after figuring it out but its more important to not break stuff.

In the mean time you can pop the select modifier in your own app using php please make:modifier Select.

@jasonvarga jasonvarga merged commit 211dcac into 5.x May 29, 2024
18 checks passed
@jasonvarga jasonvarga deleted the revert-select-modifier branch May 29, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select modifier conflicts with nav tag's select param
2 participants