Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Add validation to asset containers #10227

Merged
merged 25 commits into from
Jun 4, 2024

Conversation

edalzell
Copy link
Contributor

@edalzell edalzell marked this pull request as draft May 29, 2024 22:00
@edalzell edalzell changed the title Add validation to asset containers [5.x] Add validation to asset containers May 29, 2024
@edalzell edalzell marked this pull request as ready for review May 29, 2024 22:34
@edalzell
Copy link
Contributor Author

@jasonvarga no UI on this yet, is this fine or do you think it's required to have one?

@duncanmcclean
Copy link
Member

@jasonvarga no UI on this yet, is this fine or do you think it's required to have one?

I'm no Jason but I'd say we probably need a UI for it.

Otherwise, folks might not know about the fact the setting exists or might try and add values directly in the file which might not work, whereas if there's a UI, we can at least guide them somewhat.

@edalzell
Copy link
Contributor Author

Potential improvements:

  • makes the Rules a true component and use it in the FieldConditionsBuilder
  • naming is hard
  • keep the tabs?

@edalzell edalzell requested a review from jasonvarga May 30, 2024 19:11
@edalzell
Copy link
Contributor Author

Ready now @jasonvarga

even though the return is technically only half right, but it matches the other fluent ones for now
@jasonvarga jasonvarga merged commit ab0084d into statamic:5.x Jun 4, 2024
16 checks passed
@edalzell edalzell deleted the feature/asset-container-validation branch June 4, 2024 19:04
@toxsick
Copy link

toxsick commented Jun 5, 2024

Hey guys I am getting Assets fieldtype is missing the "container" option. after release v5.7.0 when I try to open any collection entry:

Monosnap An asset container has not been configured 2024-06-05 20-15-56

But all my type: assets fields also have an container: <valid_container_name> defined. I guess this is related to the changes here.

Any idea what I could check? v5.6.2 works without problems.

Thanks and regards!

@jasonvarga
Copy link
Member

This is fixed in #10272 and will be released shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants