Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix broken docs URLs; rename docs URL redirect to permalink #10249

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

rob
Copy link
Contributor

@rob rob commented Jun 2, 2024

There were two templates not referencing the docs URL correctly:

  • resources/views/assets/index.blade.php
  • resources/views/collections/empty.blade.php

These show up like this (using Collections as an example):

image

For example:

@include('statamic::partials.docs-callout', [
    'topic' => __('Assets'),
    'url' => 'assets'
])

Instead of:

@include('statamic::partials.docs-callout', [
    'topic' => __('Assets'),
    'url' => Statamic::docsUrl('assets')
])

In addition, resources/views/collections/index.blade.php was set up correctly, but pointing to https://statamic.dev/collections-and-entries which just redirects to https://statamic.dev/collections. This changes that so it's uniform with the empty.blade.php changes.

Copy link
Member

@duncanmcclean duncanmcclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jasonvarga jasonvarga merged commit 8fc247a into statamic:5.x Jun 3, 2024
17 checks passed
@rob rob deleted the fix/invalid-docs-url branch June 3, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants