[5.x] Fix broken revision links on unpublished entries #10330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10331
When clicking on the 'View History' button of an unpublished entry in the CP, the revision history panel loads indefinitely.
The called route
cp/collections/{collection}/entries/{entry}/revisions
fails with error 500.Apparently the working copy of the entry included in the entry's list of revisions has no id, as it is not associated with another revision. But this id is necessary to create a link in the list of revisions.
Using an empty link fixes this problem, as the working copy only exists locally and no revision shall be showed on click anyway.
Note: I was not able to find any tests of the
EntryRevisionsController
so I adapted a test related to this use-case. Feel free to shift it to the correct location.See also: #10057