-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nav tag ignores select #10503
Comments
The We have an draft pull request to add it back, but we haven't got around to finishing it off yet, see #10226. |
Probably worth removing from the docs until it's back? |
A comment on that PR, it's not just useful for speed. Here is a use case: The hero and top nav area can be green or orange, each page can differ. This is stored for each entry as a variable, i.e. nav_bg. When the view for that entry loads that sets the nav's bg, great. That entry is also part of the nav, because the nav is part of that nav area, for just that iteration of the loop that nav_bg variable then is different to the current entry's value. This now messes up the colours for the hover state and dropdown colours etc. Just being able to select only the title/url would fix this. tl;dr if you could add it back that would be great as it's not just for performance in some cases! |
Another common use case for the select parameter is limiting the Json data passed to a VueJS navigation component. Modifying nav data to Json is also much slower because of the missing select functionality. |
Bug description
select
ing fields for thenav
tag appears to be ignored and all fields are selected regardlessHow to reproduce
This still outputs the
url
s for each entry in the main nav, it shouldn't as they haven't been selectedLogs
No response
Environment
Installation
Fresh statamic/statamic site via CLI
Additional details
No response
The text was updated successfully, but these errors were encountered: