[5.x] Prevent autoloading addon files causing exception when called early

[ryanmitchell]

Since #9270 issues have been reported with add-ons that include console commands (#10873)

This PR updates the logic around the command autoloading to ensure we only run that once the app is booted.

Closes #10873

[jasonvarga]

This feels like in some situations commands wouldn't get loaded at all? This condition is only evaluated one time.

[ryanmitchell]

They still appeared for me and I ran artisan list and I could run the commands. I tested it by removing the commands from being manually registered.

[jasonvarga]

I see the issue.

Spatie's Responsive Images addon is manually calling bootCommands() in their boot method. Then Statamic will call bootCommands again once Statamic is actually ready.

They don't need to call that method.

This isn't an issue with just commands, it would be an issue for any of the bootSomething methods if you call it in boot.

I think a better fix would be to catch NotBootedException within autoloadFilesFromFolder and return nothing.

[ryanmitchell]

Nice catch. Thanks.