[5.x] Prevent protected pages being cached

[duncanmcclean]

This pull request fixes an issue where protected pages would be staticly cached, unless manually excluded in the static_caching.php config file.

Closes statamic/ideas#190.

[daun]

@duncanmcclean Is there a way of reverting to the previous behavior if required? I'm currently relying on caching protected pages in a project. There's a lot of them and the server is really slow :(

[jasonvarga]

We could, but you're aware of the issue this was fixing, right? They become unprotected once cached.

[daun]

@jasonvarga In fact, I wasn't aware. That definitely sounds like something to avoid at all cost. I need to check real quick if the site in question requires a fix on our end in this case 🤠 Looks like it.

The best strategy for caching protected pages would probably be namespacing the cached pages by the user or login state, a bit like the {{ cache scope="user" }} tag would.

[jasonvarga]

Definitely. I'm sure there's an feature request open already to support that.

[duncanmcclean]

Definitely. I'm sure there's an feature request open already to support that.

There is - go and give statamic/ideas#1234 a 👍.