Add GlideImageGenerated event to ImageGenerator #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance to get this in @jasonvarga ? |
|
Thanks for the PR. I haven't merged this yet because of #1892 which might affect this event. |
|
I was worried that once we switch to using Filesystem disks in that PR, that the path in this event would change. But since it's already relative, it wouldn't. 👍 Once that PR/feature is merged, this event will get a $disk property added to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a missing event to /Statamic/Imaging/ImageGenerator. It was already noted as a TODO and is implemented pretty much the same as it was in V2.