Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type of search result missing in global search #2332

Closed
sauerbraten opened this issue Aug 31, 2020 · 3 comments
Closed

Type of search result missing in global search #2332

sauerbraten opened this issue Aug 31, 2020 · 3 comments

Comments

@sauerbraten
Copy link
Contributor

sauerbraten commented Aug 31, 2020

Bug Description

The type of the result (what collection/container/...) is missing from results in the global search.

Looking into the JSON response received in the frontend, the respective field, e.g. collection, is just an empty object when it should contain the handle.

How to Reproduce

Search for anything in the global search bar. Results don't have their type in grey caps on the right side like they used to.

Extra Detail

Before:

image

Now:

image

Environment

Statamic version: d54f9d1

PHP version: 7.3

@jasonvarga
Copy link
Member

(Please put the commit sha in your issues rather than just HEAD. We don't know where the HEAD is.)

@sauerbraten
Copy link
Contributor Author

sauerbraten commented Sep 2, 2020

Yeah that was stupid :D We found this on 6aef808 and it's still this way on d54f9d1.

@jackmcdade jackmcdade added the bug label Sep 15, 2020
@jackmcdade
Copy link
Member

Confirmed, i can recreate this. Definitely seems like a modified lower level class change somewhere did it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants