Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added down method to Statamic Auth Migrations #2546

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Added down method to Statamic Auth Migrations #2546

merged 2 commits into from
Sep 28, 2020

Conversation

duncanmcclean
Copy link
Member

This pull request adds a down method to the auth database migration run by users who want to move their site's users to a database.

Previously, there was no down method that would drop columns added by the up method.

This PR closes #2543

@duncanmcclean duncanmcclean mentioned this pull request Sep 25, 2020
Closed
michaellindahl
michaellindahl reviewed Sep 25, 2020
View reviewed changes
Copy link

@michaellindahl michaellindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also reset the password field back to required?

$table->string('password')->change();

@jasonvarga jasonvarga merged commit 6f45557 into statamic:master Sep 28, 2020
@jasonvarga
Copy link
Member

Thanks Duncan

@duncanmcclean duncanmcclean deleted the add-down-method-to-auth-migrations branch September 28, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaellindahl michaellindahl michaellindahl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User migrations - Add down() function
3 participants
@duncanmcclean @jasonvarga @michaellindahl