Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Listing component a Global Mixin #2602

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Make Listing component a Global Mixin #2602

merged 1 commit into from
Oct 7, 2020

Conversation

duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Oct 6, 2020

This pull request makes the components/Listing.vue component a global mixin. This means that addon developers no longer need to do imports from vendor directories to use this component.

Instead, now it can be imported as a mixin:

Before:

import Listing from "../../../vendor/statamic/cms/resources/js/components/Listing";

export default {
    components: {
        Listing,
    },
}

After:

export default {
    mixins: [Listing],
}

This PR closes #2559.

@jasonvarga jasonvarga merged commit 57cc9c1 into statamic:master Oct 7, 2020
@duncanmcclean duncanmcclean deleted the feature/listing-mixin branch October 7, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listing.vue should be global for addon builders
2 participants