-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve query params manipulation #2638
Merged
jasonvarga
merged 8 commits into
statamic:master
from
piljac1:feature/improve-query-params-manipulation
Oct 13, 2020
Merged
Improve query params manipulation #2638
jasonvarga
merged 8 commits into
statamic:master
from
piljac1:feature/improve-query-params-manipulation
Oct 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
requested changes
Oct 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great.
If you could apply the simple style changes listed here, that would be great.
Done ! |
jasonvarga
approved these changes
Oct 13, 2020
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the following:
current_full_url
cascade contextual variable which behaves the same ascurrent_url
but includes query parametersadd_query_param
modifier which adds the specified key/value pair to the URL as a valid query paramset_query_param
modifier which adds the specified key/value pair to the URL (or updates the matching key) as a valid query paramremove_query_param
modifier which removes the query param matching the specified key (if it exists) from the URLUsage
{{ url add_query_param="category|dogs" }} {{ url set_query_param="category|dogs" }} {{ url remove_query_param="category" }} <!-- or --> {{ url add_query_param:category:dogs }} {{ url set_query_param:category:dogs }} {{ url remove_query_param:category }}
Todo list
current_full_url
cascade contextual variable which returns the complete URLadd_query_param
modifier which adds the specified key/value pair to the URL as a valid query paramset_query_param
which adds the specified key/value pair to the URL (or updates the matching key) as a valid query paramremove_query_param
which removes the query param matching the specified key (if it exists) from the URLAs for the implementation, there's a way of doing it with regex, but it's not much shorter, so contact me if you want a regex version (already saved a version aside for the
setQueryParam
modifier).