Addons can get their directory without needing it in the manifest #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you run
php please addons:discover, (which happens when you composer install) it'll generate a cache file inbootstrap/cache/addons.phpthat has information about all the addons.One of the things that get stored in there are the paths of each addon. It's a full path so it might be something like
/Users/jason/addons/addon-name.This isn't an issue if you're using Git and Composer to deploy, because the contents of
bootstrap/cachewill be ignored and regenerated whenever you composer install on the server.However, some users don't use Composer on their server, and just plop files up there through FTP. Now the server will see paths from the user's local dev environment instead of the server's paths, and things will break.
This PR makes it so that directories aren't stored in the manifest, making the file more portable.
See statamic/seo-pro#135