Stache Locks #2794
Merged
Stache Locks #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for locks within the Stache.
If a request is made on the site while the stache is being warmed, it will just wait until the warming is finished. This prevents the subsequent response from triggering another cache build, which would increase CPU and memory usage.
If the second request (any subsequent request) waits for 30 seconds (configurable) it'll exit with a 503 status, and a meta refresh tag that'll just re-request the page.
At the moment it only locks when "warming". e.g. when you run
php please stache:warm.More locking features will be added later, like Redis support, and cache updates outside of the stache:warm command.
Closes #552