Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension file generation commands default to the App directory #6

Closed
2 tasks done
jasonvarga opened this issue Dec 7, 2017 · 4 comments
Closed
2 tasks done
Assignees

Comments

@jasonvarga
Copy link
Member

jasonvarga commented Dec 7, 2017

  • Generator php please make:tags Something should output to app/Tags/Something.php with an App\Tags namespace.
  • We could add an argument to specify an addon location instead, to mimic v2 behavior.
@jesseleite jesseleite self-assigned this Dec 12, 2018
@jasonvarga
Copy link
Member Author

I reckon we could add a setting to config/system.php (at least temporarily) that's like this:

'addons_path' => base_path('addons')

and you could use that path when you add the --addon=MyAddon option?

@jasonvarga
Copy link
Member Author

In my opinion, please make:addon Foo should just give you the bones, which in v3 is just a composer.json and service provider - and dump it into {addons_path}/Foo

I'm not sure how useful the whole interactive thing and/or mega-file-dump was.

@jesseleite
Copy link
Member

Yeah let's keep it simple by default.

We could always add that stuff in later, and it could even be opt-in with -i for interactive, similar to how make:model SomeModel is bare bones, but if you pass -a you get all this...

-a, --all    Generate a migration, factory, and resource controller for the model

@jesseleite
Copy link
Member

jesseleite commented Jan 5, 2019

Solved the addon location argument in commands like make:tag by asking composer for the addon path, no config needed for that part 🤘

The above ideas could still apply when we flesh out a make:addon command though.

@what-the-diff what-the-diff bot mentioned this issue Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants