-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Add filtering to form submissions listing #8906
Merged
jasonvarga
merged 14 commits into
statamic:master
from
ryanmitchell:feature/filters-on-form-submissions
Apr 8, 2024
Merged
[5.x] Add filtering to form submissions listing #8906
jasonvarga
merged 14 commits into
statamic:master
from
ryanmitchell:feature/filters-on-form-submissions
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
changed the title
[4.x] Add filtering to form submissions listing
[5.x] Add filtering to form submissions listing
Apr 5, 2024
we're filtering form submissions, not forms
duncanmcclean
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds filtering to the form submissions view:
I've re-used the same approach from the entry listing views. This means I've needed to add the form submissions to an ItemQueryBuilder to allow the QueriesFilters trait to work.If #6455 were to merge this could be removed in favour of using the query submission builder, alongside updating the search and order by methods.As the date is included as a filter, this should be able to close #6135