Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Add filtering to form submissions listing #8906

Merged

Conversation

ryanmitchell
Copy link
Contributor

@ryanmitchell ryanmitchell commented Nov 1, 2023

This PR adds filtering to the form submissions view:

Screenshot 2023-11-01 at 14 14 27

I've re-used the same approach from the entry listing views. This means I've needed to add the form submissions to an ItemQueryBuilder to allow the QueriesFilters trait to work.

If #6455 were to merge this could be removed in favour of using the query submission builder, alongside updating the search and order by methods.

As the date is included as a filter, this should be able to close #6135

@duncanmcclean
Copy link
Member

If #6455 were to merge this could be removed in favour of using the query submission builder, alongside updating the search and order by methods.

I think we should probably wait until #6455 has been merged so we can use the "real" query builder. I'll mark this as a draft in the meantime.

@duncanmcclean duncanmcclean changed the base branch from 4.x to master April 5, 2024 16:02
@duncanmcclean duncanmcclean changed the title [4.x] Add filtering to form submissions listing [5.x] Add filtering to form submissions listing Apr 5, 2024
@duncanmcclean duncanmcclean marked this pull request as ready for review April 5, 2024 17:13
@duncanmcclean duncanmcclean self-requested a review April 5, 2024 17:14
@jasonvarga jasonvarga merged commit fbf7caf into statamic:master Apr 8, 2024
16 checks passed
@ryanmitchell ryanmitchell deleted the feature/filters-on-form-submissions branch April 8, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

View form submission data filter
3 participants