[5.x] Ensure structured collections are ordered by order by default
#9704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When we document this in the upgrade guide, we should mention that it'll affect the order in the CP listing (table mode) too. It was previously sorted by title, but now it mimics the page tree view order like this:
|
jasonvarga
deleted the
ensure-default-sort-for-structured-collection-is-order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request tweaks the logic in the
Collection@sortFieldmethod so that by default, "structured collections" are ordered using theorderfield, instead of thetitlefield.We already default "orderable collections" (so, ordered collections where max depth = 1) to
order, so that makes it true of "structured collections" too.Closes #9429.
Related: #8810