Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Replicator "add set" button label option #9806

Merged
merged 5 commits into from
May 23, 2024

Conversation

godismyjudge95
Copy link
Contributor

Closes:

This PR adds a simple text config option to the replicator field. The option is defaulted to empty so nothing about the default behavior changes.

It allows one to customize the labels like so:

image

image

@godismyjudge95
Copy link
Contributor Author

Alternatively, I could change this so that it replaces the + icon entirely with the label. Similar to how the grid "add row" button works

@duncanmcclean duncanmcclean changed the base branch from 4.x to 5.x May 14, 2024 14:17
@duncanmcclean duncanmcclean changed the title [4.x] Replicator "add set" button label option [5.x] Replicator "add set" button label option May 14, 2024
@jackmcdade jackmcdade merged commit 773ba75 into statamic:5.x May 23, 2024
16 checks passed
@godismyjudge95 godismyjudge95 deleted the set-button-label branch May 24, 2024 00:39
@toxsick
Copy link

toxsick commented May 29, 2024

Somehow the small "plus" buttons that are shown on hover between replicator fields are gone in the latest release (v5.6.0):

Monosnap @Robert Stehr - Discord 2024-05-29 16-01-39

Could this be related to these changes somehow? I don't see any other replicator related changes in the release.

regards

@jasonvarga
Copy link
Member

@toxsick Do you have any javascript errors?

@godismyjudge95
Copy link
Contributor Author

Somehow the small "plus" buttons that are shown on hover between replicator fields are gone in the latest release (v5.6.0):

Could this be related to these changes somehow? I don't see any other replicator related changes in the release.

regards

Figured it out, PR submitted

@duncanmcclean
Copy link
Member

duncanmcclean commented May 29, 2024

@toxsick Can you try updating to v5.6.1? It included #10217, which should have fixed it.

@toxsick
Copy link

toxsick commented May 30, 2024

Hey guys, jeah as @jasonvarga suggested I was seeing js errors. Everything works again in v5.6.1 now. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants