Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Make the SVG tag fail gracefully when src value is empty #9905

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

duncanmcclean
Copy link
Member

This pull request makes it so the {{ svg }} tag fails gracefully when the provided src value is empty. This matches how the SVG tag handled empty src values in v4.

The example given in #9902, was that of an icon field without any value:

{{ svg src="{{ foo }}" }}

Fixes #9902.

@jasonvarga jasonvarga merged commit 2122b85 into master Apr 16, 2024
32 checks passed
@jasonvarga jasonvarga deleted the fix/make-svg-tag-fail-gracefully branch April 16, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants