Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Fix missing composer binary (starter kits couldn't be installed) #9950

Merged
merged 14 commits into from
Apr 23, 2024

Conversation

duncanmcclean
Copy link
Member

This pull request fixes an issue when installing starter kits, where Statamic was unable to find the Composer binary which caused starter kit installs to fail.

Previously, we were requiring composer/composer in our composer.json, however, we removed this dependency yesterday in #9947 since it wasn't really needed anymore and was causing issues.

However, in removing the dependency, the composer binary is no longer in the vendor/bin directory, so we need to use the globally installed Composer binary instead.

Related: #9947
Fixes statamic/cli#70

@duncanmcclean duncanmcclean marked this pull request as draft April 23, 2024 13:57
@jasonvarga jasonvarga changed the title [4.x] Fix installing starter kits [4.x] Fix missing composer binary (starter kits couldn't be installed) Apr 23, 2024
@jasonvarga jasonvarga marked this pull request as ready for review April 23, 2024 19:36
@jasonvarga jasonvarga merged commit 08e3c55 into 4.x Apr 23, 2024
36 checks passed
@jasonvarga jasonvarga deleted the fix/installing-starter-kits branch April 23, 2024 19:38
@the-goodies
Copy link

Bug still exists on Windows 11: #9952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install Starter Kits currently
3 participants