Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Vite content tag #9972

Closed
jimblue opened this issue Apr 30, 2024 · 3 comments · Fixed by #9973
Closed

Add missing Vite content tag #9972

jimblue opened this issue Apr 30, 2024 · 3 comments · Fixed by #9973

Comments

@jimblue
Copy link
Contributor

jimblue commented Apr 30, 2024

Description

It's actually not possible to inline asset using {{ vite:content }} while Laravel offer a method for that: Laravel Vite inline assets

Environment

Environment
Application Name: Statamic
Laravel Version: 10.48.9
PHP Version: 8.3.6
Composer Version: 2.7.4
Environment: local
Debug Mode: ENABLED
URL: statamic.test
Maintenance Mode: OFF

Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: NOT CACHED

Drivers
Broadcasting: null
Cache: redis
Database: mysql
Logs: stack / single
Mail: smtp
Queue: redis
Session: file

Statamic
Addons: 1
Antlers: runtime
Sites: 1
Stache Watcher: Enabled
Static Caching: Disabled
Version: 4.57.2 PRO

Statamic Addons
statamic/seo-pro: 5.4.4

Installation

Fresh statamic/statamic site via CLI

Antlers Parser

Runtime (default)

@duncanmcclean
Copy link
Member

It's not really a bug, since it was added after we built the {{ vite }} tag but we can certainly add it.

@jimblue jimblue changed the title Missing {{ vite:content }} tag Add Missing {{ vite:content }} tag Apr 30, 2024
@jimblue jimblue changed the title Add Missing {{ vite:content }} tag Add missing Vite content tag Apr 30, 2024
@jimblue
Copy link
Contributor Author

jimblue commented Apr 30, 2024

It's not really a bug, since it was added after we built the {{ vite }} tag but we can certainly add it.

I've rewrite the commit message, the issue description and the PR content @duncanmcclean. 😉

@jimblue
Copy link
Contributor Author

jimblue commented Apr 30, 2024

Here is the pull request #9973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants