Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning("spline basis weights close to boundaries; try reducing spline_df") #13

Open
paulinetrinh opened this issue Jul 27, 2022 · 3 comments

Comments

@paulinetrinh
Copy link
Collaborator

suppressWarnings() about spline basis weights close to boundaries. Theoretically, having spline basis weights close to boundaries could change the asymptotics of our estimators. However, in our simulation output we didn't see this occurring. Currently, these warnings are being suppressed since there is no empirical evidence that it makes a difference in practice.

TODO: evaluate the impact of spline basis weights being close to boundaries on our estimators via simulation. If there is an issue consider using a bootstrap to address the problem

@adw96
Copy link
Collaborator

adw96 commented Jul 27, 2022

In the meantime (though I do want this labelled high priority), can we suppress the warnings at intermediate steps, and only output a warning if it happens on the final iteration before convergence?

@paulinetrinh
Copy link
Collaborator Author

Comparison of happi 2 vs. 3 knot splines on prausnitzii dataset for gene L-rhamnose isomerase
happi_f_issue13

Screen Shot 2022-07-27 at 1 16 31 PM

@paulinetrinh
Copy link
Collaborator Author

In the meantime (though I do want this labelled high priority), can we suppress the warnings at intermediate steps, and only output a warning if it happens on the final iteration before convergence?

Current implementation of happi suppresses warnings at intermediate steps and only outputs a warning if it happens on the final iteration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants