Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate a better concurrency model or description #108

Closed
lalexgap opened this issue Sep 26, 2022 · 1 comment
Closed

Investigate a better concurrency model or description #108

lalexgap opened this issue Sep 26, 2022 · 1 comment
Assignees
Labels
🇵🇹 Lisbon Tasks and issues we should attempt to resolve before we go to Lisbon

Comments

@lalexgap
Copy link
Contributor

Right now the way concurrency works in our test can be kind of hard to understand. We specify a ConcurrentPaymentJobs value ( typically from 1 to 50).

This is the number of payment "jobs" a client maintains. A payment job is the process of

  • opening a virtual channel
  • sending a few payments on it
  • close the virtual channel

We run these jobs in their own go-routine which means the client handles concurrent API calls (which it handles fine).

I think this model works fine although may be resource intensive for large ConcurrentPaymentJobs values as we're spinning up a go routine for each job.

However I'm not sure this model reflects how we'd expect it to be used in retrieval market. It's also hard to quickly describe what this value means. It would be nice if the way we controlled load (concurrent or otherwise) was simple to explain and understand.

In the context of a retrieval market is there a better way to model load on a client? Is there any way we could simplify our model so it's easy to describe and understand?

@lalexgap lalexgap added the 🇵🇹 Lisbon Tasks and issues we should attempt to resolve before we go to Lisbon label Sep 26, 2022
@lalexgap lalexgap self-assigned this Sep 26, 2022
@lalexgap
Copy link
Contributor Author

Based on standup discussion (see https://www.notion.so/statechannels/Benchmarks-and-metrics-for-testground-e40facd47c7d4487bb8e1a2836690bb5) we've decided that the current "concurrency" model is good enough. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🇵🇹 Lisbon Tasks and issues we should attempt to resolve before we go to Lisbon
Projects
None yet
Development

No branches or pull requests

1 participant