Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New settings and clean up #1820

Merged
merged 5 commits into from
Nov 23, 2024
Merged

New settings and clean up #1820

merged 5 commits into from
Nov 23, 2024

Conversation

sourishkrout
Copy link
Member

@sourishkrout sourishkrout commented Nov 22, 2024 •
edited
Loading

  1. Shorten labels in the notebook toolbar, e.g., Send Feedback -> Feedback.
  2. Introduce new setting (runme.terminal.interactiveIsDefault) to allow toggling between (non)-interactive being default.
  3. Persist terminal rows when modified in the notebook UX.
  4. When terminal dimensions are updated, Account for height, not only width.
  5. Debounce messaging to reduce message serialization/deserialization.

pastuxso
pastuxso approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@pastuxso pastuxso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sourishkrout sourishkrout merged commit 0c8fd3d into main Nov 23, 2024
1 check passed
@sourishkrout sourishkrout deleted the seb/settings branch November 23, 2024 17:31
@sourishkrout sourishkrout mentioned this pull request Nov 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pastuxso pastuxso pastuxso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sourishkrout @pastuxso