Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower bundle size #75

Merged
merged 3 commits into from
Dec 13, 2022
Merged

Lower bundle size #75

merged 3 commits into from
Dec 13, 2022

Conversation

sourishkrout
Copy link
Member

@sourishkrout sourishkrout commented Dec 5, 2022

Do we still have to include node_modules in packaging?

I believe in the past we kept the node_modules because of the web component stuff, no?

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann
Copy link
Contributor

Do we still have to include node_modules in packaging?

We probably could strip it further down but I still got some dependencies like got or undici that we would need to bundle into the extension bundle otherwise. I don't see a big problem shipping with node_modules in place.

@sourishkrout sourishkrout merged commit 8d92792 into main Dec 13, 2022
@sourishkrout sourishkrout deleted the bundle-size branch December 13, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants